create-github-app failing

Waterdrips commented 4 years ago

./ofc-bootstrap create-github-app --root-domain ofc.example.com --name ofc1-example-com

This creates the page, then on submit im not getting a github app details filled in.

Expected Behaviour

Github App created with values

Current Behaviour

Im getting blank fields in the github app when submitting from our page.

Possible Solution

I wonder if the API has changed github's side or we have introduced an issue.

Steps to Reproduce (for bugs)

build from master branch
ofc-bootstrap create-github-app --root-domain ofc.heyal.uk --name ofc1-heyal-uk

Context

Your Environment

faas-cli version ( full output ):
Docker version docker version (e.g. Docker 17.0.05 ):
Kubernetes version kubectl version:
Are you using faas-netes or the Operator?
Operating System and version (e.g. Linux, Windows, MacOS):
Link to your project or a code example to reproduce issue:
Please also follow the troubleshooting guide and paste in any other diagnostic information you have:

gjolund commented 4 years ago

I am also experiencing this issue

OS: Ubuntu 18 Docker: 19 Kubectl: 1.18

alexellis commented 4 years ago

I know that you changed this code recently Alistair, can you take point on this if it's broken and find out either way what the solution is?

alexellis commented 4 years ago

@Waterdrips

Waterdrips commented 4 years ago

@alexellis it looks like github have removed the ability to create apps using the API.

https://developer.github.com/v3/apps/ has no reference to the url we were using https://github.com/settings/apps/new

alexellis commented 4 years ago

API: https://developer.github.com/v3/apps/#create-a-github-app-from-a-manifest

And workflow: https://developer.github.com/apps/building-github-apps/creating-github-apps-from-a-manifest/

Waterdrips commented 4 years ago

oh yeah, DOH!

So it looks like I'm being redirected through /login before being sent back to apps/new and we loose the manifest= parameter. Therefore nothing is filled in on the app.

Waterdrips commented 4 years ago

Iv opened a support ticket with github.

Waterdrips commented 4 years ago

Github have confirmed there is an issue here and raised a ticket for their engineering team to look into.

They said they don't have a timescale at the moment but would contact me when they have more info.

Waterdrips commented 4 years ago

/close

This has been confirmed FIXED by github :tada:

openfaas / ofc-bootstrap