Open LucasRoesler opened 3 years ago
I tried adding this to my init.yaml
and it did not work
- name: "registry-secret"
files:
- name: "config.json"
value_from: "~/.docker/config.json"
filters:
- "default"
namespace: "openfaas"
Adding both of these did make progress
- name: "registry-secret"
files:
- name: "config.json"
value_from: "~/.docker/config.json"
filters:
- "default"
namespace: "openfaas"
- name: "registry-pull-secret"
files:
- name: ".dockerconfigjson"
value_from: "~/.docker/config.json"
namespace: "openfaas-fn"
filters:
- "default"
type: "kubernetes.io/dockerconfigjson"
I went back through the ofc-bootstrap logs and found this
2020/12/05 16:55:08 Creating Ingress Controller
helm upgrade --install nginxingress ingress-nginx/ingress-nginx --set rbac.create=true
Error: failed to download "ingress-nginx/ingress-nginx" (hint: running `helm repo update` may help)
2020/12/05 16:55:08 1 helm upgrade --install nginxingress ingress-nginx/ingress-nginx --set rbac.create=true
Error: failed to download "ingress-nginx/ingress-nginx" (hint: running `helm repo update` may help)
This should probably be a critical error and stop the bootstrap
Same for minio
2020/12/05 16:55:09 Creating Minio
Error: failed to download "minio/minio" (hint: running `helm repo update` may help)
2020/12/05 16:55:09 Error: failed to download "minio/minio" (hint: running `helm repo update` may help)
@Waterdrips PTAL
Thanks for the report
I thought we fixed this already?
Warning: extensions/v1beta1 Ingress is deprecated in v1.14+, unavailable in v1.22+; use networking.k8s.io/v1 Ingress
ingress.extensions/openfaas-ingress created
2020/12/05 16:55:12 0 ingress.extensions/openfaas-ingress created
Warning: extensions/v1beta1 Ingress is deprecated in v1.14+, unavailable in v1.22+; use networking.k8s.io/v1 Ingress
Warning: extensions/v1beta1 Ingress is deprecated in v1.14+, unavailable in v1.22+; use networking.k8s.io/v1 Ingress
ingress.extensions/openfaas-auth-ingress created
2020/12/05 16:55:12 0 ingress.extensions/openfaas-auth-ingress created
Warning: extensions/v1beta1 Ingress is deprecated in v1.14+, unavailable in v1.22+; use networking.k8s.io/v1 Ingress
sealed secrets also fails to download
Error: failed to download "stable/sealed-secrets" (hint: running `helm repo update` may help)
2020/12/05 16:55:13 Error: failed to download "stable/sealed-secrets" (hint: running `helm repo update` may help)
ok, so I propose:
1) get.sh (fixed) (thanks)
2) Update the github app generation to save/append/merge the values into the files (either by default, or with a flag). Blog post(s) need updating to use new flag or new default (think theres some use of this command in the openfaas blogs too)
3) Logging options in ofc-bootstrap need re-addressing. We might want to hide everything thats not an "issue" or "error" (use a lobber and set default to info or warn, allow users to specify debug) Its hard to see whats an issue or not
4) Blog posts and user_guide should be updated to be adding config to a new file, then using the merge functionality to use this config. This will reduce the complexity and make it more obvious what a user needs to set.
5) Blog post needs clarification on registry
setting in init.yaml and the ofc-bootstrap registry-creds
command.
6) Blog post needs updating for the above, to use correct config for registry.
7) Yes, ofc-bootstrap needs to run in root (well it needs files that are in the repo for the github app creation) We could inline those files to make it not required
8) Blog post needs looking at for the k3s config on ingress
(sections in comments not in main section)
9) Some of the helm install commands are not doing helm repo add and helm repo update (minio, sealed secrets ) Looking at the code i cant see it ever doing those, might need amending. I want to move to using arkade to install these apps so we can probably do that sooner rather than later to work round this. Iv never seen an issue with these before, possibly because I have them added from elsewhere and the app does a helm repo update a few times.
10) Look at ingress to see which endpoint is being used, move to networking.k8s.io/v1
where its not been done.
I am working through the steps documented in https://blog.alexellis.io/openfaas-cloud-for-development/ but can not complete the installation
get.sh
script is incorrect, this is fixed with https://github.com/openfaas/ofc-bootstrap/pull/238ofc-bootstrap
will accept multiple files, the user should just create aninit.yaml
with only the edited values.my best guess is that i can edit the yaml file to point at
~/.docker/config.json
It appears the ofc-bootstrap must be run inside the root of the ofc-bootstrap project, this is not clear or noted in blog post. I was running the command in a sandbox folder and got this error
It specifically mentions nginx, but i don't have any nginx SVCs running
was i supposed to do something with inlets? very early in the blog post it is installed, but then I do nothing else with it directly. Additionally, nothing was yet created in digital ocean