openfaas / openfaas-cloud

The Multi-user OpenFaaS Platform
https://docs.openfaas.com/openfaas-cloud/intro/
MIT License
770 stars 227 forks source link

Invalid Reference Format - buildkit, names with whitespace (Gitlab) #657

Closed Waterdrips closed 4 years ago

Waterdrips commented 4 years ago

Gitlab integration is possibly using the full name field, which could be causing buildkit to append an invalid value (a space) into the ref field.

I think also we are using a mismatch of fullname and username somewhere, as its been reported that:

if the full name field value doesn't match the gitlab login username, dashboard won't list the user's function.

see this issue for context https://github.com/openfaas/openfaas-cloud/issues/644

Expected Behaviour

A name with whitespace can be handled in the application

Current Behaviour

Buildkit ref has whitespace, which is causing some issues (https://github.com/openfaas/openfaas-cloud/issues/644)

Possible Solution

Steps to Reproduce (for bugs)

  1. Gitlab name with whitespace
  2. Try and deploy a function
  3. Invalid ref format in buildkit

Context

Your Environment

alexellis commented 4 years ago

This is an expected error, there are some GitLab usernames which cannot be supported in a Kubernetes Pod name or Docker image name or tag.

Waterdrips commented 4 years ago

/close

This is an expected error, there are some GitLab usernames which cannot be supported in a Kubernetes Pod name or Docker image name or tag.

ill close then. Thanks

alexellis commented 4 years ago

How was the issue discovered? Was it reported by a user?

There is a GitLab documentation page, so it would make sense to add a note there

Waterdrips commented 4 years ago

644