search

openfaas / openfaas-cloud

The Multi-user OpenFaaS Platform
https://docs.openfaas.com/openfaas-cloud/intro/
MIT License
770 stars 227 forks source link

Upgrade derek dependency to 0.10.2 #664

Closed Waterdrips closed 4 years ago

Waterdrips commented 4 years ago

Signed-off-by: Alistair Hey alistair@heyal.co.uk

Description

This version of derek includes an update to remove a soon to be depricated API endpoint on github. Reference: https://developer.github.com/changes/2020-04-15-replacing-create-installation-access-token-endpoint/

This release will need the following 3 containers bumped:

github-status
git-tar
buildshiprun

note: buildshiprun wasnt using Derek for auth but had it in the Gopkg

How Has This Been Tested?

A new OFC installation was created and the above 3x containers swapped for my own built versions.

A deployment was then completed using a commit from a linked git repository.

How are existing users impacted? What migration steps/scripts do we need?

Github users will need to update these 3x containers in their installations before the endpoint on github is deprecated.

The legacy "Create an installation access token" endpoint will be disabled at the earliest on October 1 2020.

Checklist:

I have:

Waterdrips commented 4 years ago

Good spots, updated to 10.2. and made changes & fixes based on suggestions, fancy giving this branch a build and try @wilsonianb

alexellis commented 4 years ago

@wilsonianb thanks for your input here. PRs are welcome - you seem to have a good handle on how things fit together. Try to keep them short & sweet. Ideally defensible - i.e. changes for a defined purpose.