Remove of-client-secret as env var from edge-auth

[Waterdrips]

Description

Edge-auth now only uses the mounted secret to read the of-client-secret for Oauth2. This is to reduce complexity in the chart and deployments.

Signed-off-by: Alistair Hey alistair@heyal.co.uk

Fixes #673

How Has This Been Tested?

the golang chart tests pass. This functionality has been in use for a long time, iv not seen the env variable being used over the secret anywhere.

How are existing users impacted? What migration steps/scripts do we need?

Checklist:

I have:

• [ ] updated the documentation and/or roadmap (if required)
• [ ] read the CONTRIBUTION guide
• [ ] signed-off my commits with git commit -s
• [ ] added unit tests

[wilsonianb]

There's a couple stray clientSecrets that are causing an error when building the edge-auth image. This fixed it for me https://github.com/wilsonianb/openfaas-cloud/commit/f02c4f69f854fdd9c880ddd28f4883d3e0677d6b

[Waterdrips]

apologies - fixed now based on your commit :+1: