openfaas / python-flask-template

HTTP and Flask-based OpenFaaS templates for Python 3
MIT License
85 stars 86 forks source link

feat: adds python27-flask-buildtools template with build tool support #3

Closed shaunc closed 4 years ago

shaunc commented 6 years ago

I'm not sure if you want to maintain this variant? I used it for a function that needed pycrypto, which needs a c complier to install. I expect it will be generally useful.

shaunc commented 6 years ago

Unfortunately it is a little less than DRY, as it copies everything except the Dockerfile. Perhaps it would be nice to have the ability of one template to extend another -- by being copied into same place, say.

Jeff-Lowrey commented 4 years ago

I realize this is a zombie PR, but the need for additional build-tools might be addressed with the addition of the debian based templates. There aren't debian based templates for python27, but those could be done instead of this PR. @alexellis WDYT?

alexellis commented 4 years ago

Python 2.7 is EOL, it is no longer supported by the PSF. https://www.python.org/doc/sunset-python-2/

Can you elaborate on what these build tools are? I see that no issue was raised as per the contribution guide to explain what this change is, why it's needed and what it does?

alexellis commented 4 years ago

Closing, feel free to raise an issue with what you need.