Remove gevent and use waitress in all templates

openfaas / python-flask-template

HTTP and Flask-based OpenFaaS templates for Python 3

MIT License

85 stars 86 forks source link

Remove gevent and use waitress in all templates #33

Closed LucasRoesler closed 4 years ago

LucasRoesler commented 4 years ago

What

Update all templates to use waitress instead of gevent. This avoids the need to install things like gcc, make, or libffi-dev into the alpine images. The user can still install these via the ADDITIONAL_PACKAGES build arg, if they are needed.

Signed-off-by: Lucas Roesler roesler.lucas@gmail.com

alexellis commented 4 years ago

Hi @LucasRoesler, I can see why we changed from gevent in the Alpine Linux variants, but was gevent needing a compilation in Debian?

LucasRoesler commented 4 years ago

Hi @LucasRoesler, I can see why we changed from gevent in the Alpine Linux variants, but was gevent needing a compilation in Debian?

yes gevent is going to require that compile stage in any installation, unless you are installing some precompiled wheel/binary from something like conda or apt-get. The same is true for Pandas, NumPy, Pillow (i think), lxml is another common dependency that i think requires development headers (it is used in xml/html parsing, e.g. Beautifulsoup uses it)