Closed rgschmitz1 closed 2 years ago
@alexellis this is :+1: but i can't merge it myself, I think you are the only one that can.
Thanks for the PR and review.
A good time to get eyes on PRs and requests like this would be at our weekly community call, feel free to see the pinned issue at: https://github.com/openfaas/faas/issues
Alex
Signed-off-by: Bob Schmitz III schmitzr1984@gmail.com
Description
TEST_ENABLED
conditional syntax to be POSIX friendly.Motivation and Context
This fixes a syntax error occurring in Debian based image templates which uses dash as the default shell.
design/approved
labelCloses #53
How Has This Been Tested?
python:3.7-alpine
andpython:3.7-slim-buster
(see https://gist.github.com/rgschmitz1/1cc3f375e582433dc80191b87d2e103e for detailed log).docker build
command for both base images.faas-cli version
):CLI: commit: b1c09c0243f69990b6c81a17d7337f0fd23e7542 version: 0.14.2
Docker version 20.10.14, build a224086
NAME="Ubuntu" VERSION="20.04.4 LTS (Focal Fossa)" ID=ubuntu ID_LIKE=debian PRETTY_NAME="Ubuntu 20.04.4 LTS" VERSION_ID="20.04" HOME_URL="https://www.ubuntu.com/" SUPPORT_URL="https://help.ubuntu.com/" BUG_REPORT_URL="https://bugs.launchpad.net/ubuntu/" PRIVACY_POLICY_URL="https://www.ubuntu.com/legal/terms-and-policies/privacy-policy" VERSION_CODENAME=focal UBUNTU_CODENAME=focal