openfaas / store

Official Function and Template Store for OpenFaaS
MIT License
163 stars 56 forks source link

OpenFaaS function for Pigo face detector #37

Closed esimov closed 6 years ago

esimov commented 6 years ago

Here is an OpenFaaS function to detect faces using the Pigo face detection library. https://github.com/esimov/pigo-openfaas

ivanayov commented 6 years ago

Thanks @esimov

Can you please open a PR?

Could you also compare the results by time/accuracy with https://github.com/openfaas/store/blob/master/store.json#L44 ? We may keep both or if yours is faster, remove the other one.

Ivana

esimov commented 6 years ago

Hey @ivanayov I just sent a PR https://github.com/openfaas/store/pull/38, however i just committed without to Signed-off. If you cannot accept it, i can make another PR.

Thank you, Endre

ivanayov commented 6 years ago

Derek close

alexellis commented 6 years ago

For future reference there is no need to create a new PR. You can amend commits using the links in the contribution guide.

esimov commented 6 years ago

Thanks Alex, i'll do so.

alexellis commented 6 years ago

Very nice @esimov, I just tested the function and it worked well 👍 🎉

Do you also have the JSON mode available which gives back the co-ordinates of the faces detected?

esimov commented 6 years ago

@alexellis yes, the response should return the coordinates of the detected faces, however the function handler does not show the json result in the response body.

j, err := json.Marshal(resp)
if err != nil {
    return fmt.Sprintf("Error encoding output: %s", err)
}

// Return face rectangle coordinates
return string(j)