Use latest jdk8 - Githubissues

tim-hellhake commented 4 years ago

Description

Motivation and Context

[x] I have raised an issue to propose this change (required)

Which issue(s) this PR fixes

Fixes #163

How Has This Been Tested?

Types of changes

[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

[x] My code follows the code style of this project.
[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
[x] I've read the CONTRIBUTION guide
[x] I have signed-off my commits with git commit -s
[ ] I have added tests to cover my changes.
[ ] All new and existing tests passed.

derek[bot] commented 4 years ago

Thank you for your contribution. I've just checked and your commit doesn't appear to be signed-off. That's something we need before your Pull Request can be merged. Please see our contributing guide. Tip: if you only have one commit so far then run: git commit --amend --signoff and then git push --force.

alexellis commented 4 years ago

As explained in the contributing guide, anonymous emails are not allowed for the purpose of the DCO, a real, valid email must be used.

Please can you read the contributing guide before submitting any more PRs?

Alex

tim-hellhake commented 4 years ago

Fixed in https://github.com/openfaas/templates/commit/329498c5ceab9f44e4960f67daed54707118381d