Update gradle to 5.1.1 - Githubissues

openfaas / templates

OpenFaaS Classic templates

https://www.openfaas.com

MIT License

276 stars 228 forks source link

Update gradle to 5.1.1 #166

Closed tim-hellhake closed 4 years ago

tim-hellhake commented 4 years ago

Description

Motivation and Context

[x] I have raised an issue to propose this change (required)

Which issue(s) this PR fixes

Fixes #165

How Has This Been Tested?

Types of changes

[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

[ ] My code follows the code style of this project.
[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
[x] I've read the CONTRIBUTION guide
[x] I have signed-off my commits with git commit -s
[ ] I have added tests to cover my changes.
[ ] All new and existing tests passed.

derek[bot] commented 4 years ago

Thank you for your contribution. I've just checked and your commit doesn't appear to be signed-off. That's something we need before your Pull Request can be merged. Please see our contributing guide. Tip: if you only have one commit so far then run: git commit --amend --signoff and then git push --force.

alexellis commented 4 years ago

Hi Tim,

I appreciate your enthusiasm, but there is lacking information on the issue template which you deleted instead of filling out. You've also not tested the change which is not going to help this PR get merged.

How Has This Been Tested?

^ this cannot be left blank

Derek has also explained how to sign-off your commit, again, you may have not read the contribution guide or the template which explains this.

I have signed-off my commits with git commit -s

^ You checked this without understanding what it means.

Please could you slow down and fill out the paperwork?

Alex