openfaas / templates

OpenFaaS Classic templates
https://www.openfaas.com
MIT License
279 stars 227 forks source link

Add java12 template #167

Closed alexellis closed 5 years ago

alexellis commented 5 years ago

Signed-off-by: Alex Ellis alexellis2@gmail.com

Description

The OpenJDK now ships on Oracle Linux 7 with a different EULA and terms. These have been mentioned in ther welcome message for unsuspecting users.

Dockerfile needed to change to accomodate the different command line commands on Oracle Linux vs Alpine Linux. The size has also increased due to no "light-weight" runtime image being found or provided at the time.

VM options had to change to -XX:+UseContainerSupport from the old flags.

Tested on Docker Swarm.

Motivation and Context

Which issue(s) this PR fixes

Fixes #146

How Has This Been Tested?

Tested with simple hello world

Types of changes

Impact to existing users

New template, new image, with new Linux base image and EULA. This is printed to users when they run faas-cli new

Checklist:

alexellis commented 5 years ago

Thanks for approving @affix

Next step is to get the libraries used in the Java templates published to a central place, so we can pull them in as a JAR.

kameshchauhan commented 5 years ago

@alexellis I would avoid commenting about use of java8 in the few files separately. But in general, there is a need to rectify the use from java8 to java12...mostly in the /bin/*.

alexellis commented 5 years ago

The bin folder should be removed.. my mistake