openfaas / templates

OpenFaaS Classic templates
https://www.openfaas.com
MIT License
279 stars 227 forks source link

Added first version dotnet core 2.2 template #177

Closed csakshaug closed 4 years ago

csakshaug commented 4 years ago

dotnet core 2.2 template

Description

This a is dotnet core 2.2 template based on the csharp template, but it also updated the base docker image location (using new Microsoft registry) and also fixed the that the handler uses dotnet core and not standard.

The csharp template has mixed with net core and standard 2.1. It also has some flaws from a "dotnet developing perspective", I have not addressed this in this pull request.

Motivation and Context

We should have updated templates both for 2.2 and 3.0. The name csharp could be misleading, my suggestion is to start using "netcore" or "netstandard" as basename instead of "csharp".

The reason why I have selected netcore is same as Microsoft using as a prefix for the framework in the csproj file.

Which issue(s) this PR fixes

Fixes #176

How Has This Been Tested?

Only testet docker build

Types of changes

Impact to existing users

None, new naming for dotnet core templates

Checklist:

derek[bot] commented 4 years ago

Thank you for your contribution. I've just checked and your commit doesn't appear to be signed-off. That's something we need before your Pull Request can be merged. Please see our contributing guide. Tip: if you only have one commit so far then run: git commit --amend --signoff and then git push --force.