Added first version dotnet core 3.0 template

csakshaug commented 4 years ago

dotnet core 3.0 template

Description

This a is dotnet core 3.0 template based on the csharp template, but it also updated the base docker image location (using new Microsoft registry) and also fixed the that the handler uses dotnet core and not standard.

The csharp template has mixed with net core and standard 2.1. It also has some flaws from a "dotnet developing perspective", I have not addressed this in this pull request.

Motivation and Context

We should have updated templates both for 2.2 and 3.0. The name csharp could be misleading, my suggestion is to start using "netcore" or "netstandard" as basename instead of "csharp".

The reason why I have selected netcore is same as Microsoft using as a prefix for the framework in the csproj file.

[x] I have raised an issue to propose this change (required)

Which issue(s) this PR fixes

Fixes #176

How Has This Been Tested?

Only testet docker build

Types of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)
[ ] Version change (see: Impact to existing users)

Impact to existing users

None, new naming for dotnet core templates

Checklist:

[x] My code follows the code style of this project.
[x] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
[x] I've read the CONTRIBUTION guide
[ ] I have signed-off my commits with git commit -s
[ ] I have added tests to cover my changes.
[ ] All new and existing tests passed.

derek[bot] commented 4 years ago

Thank you for your contribution. I've just checked and your commit doesn't appear to be signed-off. That's something we need before your Pull Request can be merged. Please see our contributing guide. Tip: if you only have one commit so far then run: git commit --amend --signoff and then git push --force.

alexellis commented 4 years ago

I suspect that .NET 3.0 is a good time for us to move to a HTTP server and of-watchdog

How about using Kestrel?

Template name dotnetcore3-http?

csakshaug commented 4 years ago

I suspect that .NET 3.0 is a good time for us to move to a HTTP server and of-watchdog

I agree

How about using Kestrel?

I do that in other projects

Template name dotnetcore3-http?

dotnetcore3-http for this one? another with kestrel etc?

alexellis commented 4 years ago

Instead of adding a STDIO template for .NET Core 3.0, let's only add a http-based template using Kestrel.

csakshaug commented 4 years ago

What are we thinking about the name?

netcore vs dotnetcore vs aspnetdotnetcore
-http, -kestrel etc
I see that in other templates we operate with major version number, how can we have support for both 2.0,2.1,2.2,3.0, 3.1 with only numbers?

burtonr commented 4 years ago

The overall proposal conversation should occur on the issue, or in the Slack channel as mentioned in the contribution guide

The conversations in the PR should be focused around the implementation details.

alexellis commented 4 years ago

Various options:

csharp-
dncore-
dotnetcore-
netcore-

alexellis commented 4 years ago

csharp-dotnetcore3.0 csharp-netcore3.0

csharp-dotnetcore3.0-kestrel csharp-netcore3.0-kestrel

csharp-3.0-kestrel

alexellis commented 4 years ago

For anyone landing here, please see: https://www.openfaas.com/blog/asp-net-core/

alexellis commented 4 years ago

I am closing out these tickets, but want the work to continue, as an of-watchdog template

openfaas / templates