Closed themoah closed 4 years ago
Thank you for your contribution. I've just checked and your commit doesn't appear to be signed-off. That's something we need before your Pull Request can be merged. Please see our contributing guide.
Tip: if you only have one commit so far then run: git commit --amend --signoff
and then git push --force
.
Thanks for the PR, can you send one over to https://github.com/openfaas-incubator/ruby-http too?
Are there breaking changes involved in moving from Ruby 2.5 to 2.7? cc @kaihoffman @andyjeffries
Hi @alexellis 2.7 implements all methods etc from previous versions, it simply adds new features. 3.0 next year will be the one with potential breaking issues.
@alexellis it's only security fixes and some major GC improvement (alongside JIT). All new features will be released with 3.0.
Let's go for it then.
bumping ruby & alpine version in dockerfile
Description
ruby 2.7 was released recently alpine 3.7 reached its EOL.
Motivation and Context
Which issue(s) this PR fixes
How Has This Been Tested?
manually build (before and after the change).
docker run -p 8080:8080 ruby-template:0.1
and thencurl localhost:8080
which returnedHello world from the Ruby template
(as expected) docker log:Types of changes
Impact to existing users
newer version with backward compatibility.
Checklist:
git commit -s