search

openfaas / templates

OpenFaaS Classic templates
https://www.openfaas.com
MIT License
279 stars 227 forks source link

Name of rootProject to be "java12" for Java12-template #187

Closed SchulteMarkus closed 2 years ago

derek[bot] commented 4 years ago

Thank you for your contribution. I've just checked and your commit doesn't appear to be signed-off. That's something we need before your Pull Request can be merged. Please see our contributing guide. Tip: if you only have one commit so far then run: git commit --amend --signoff and then git push --force.

derek[bot] commented 4 years ago

Thank you for your contribution. I've just checked and your Pull Request doesn't appear to have any description. That's something we need before your Pull Request can be merged. Please see our contributing guide.

SchulteMarkus commented 2 years ago

Closed as PR starved.

alexellis commented 2 years ago

Hi @SchulteMarkus the PR was not starved, you just didn't seem to take note of what Derek said to you.

The commits need to be signed-off, yours were not. You also need to fill out the PR template properly, again an automated bot told you that.

Contributions are welcome, but we need people to read the contribution guide and to follow it.

Alex

alexellis commented 2 years ago

In the meantime it seems like we did away with a Java12 template.

alexellis commented 2 years ago

/lock