Graduate python3-debian from incubator

LucasRoesler commented 4 years ago

Description

Copy the python3-debian template from https://github.com/openfaas-incubator/python3-debian
Update the dockerfile to be non-root, this adapts the same modifications/commands that the alpine dockerfile uses, but of course adapted to debian

Motivation and Context

[x] I have raised an issue to propose this change (required)

Which issue(s) this PR fixes

Fixes openfaas-incubator/python3-debian#10 Fixes openfaas-incubator/python3-debian#7

How Has This Been Tested?

I tested it by creating a new echo function

faas-cli new echo --lang python3-debian

I then built it using

$ faas-cli build -f echo.yml 
$ docker run --rm -d -p 8080:8080 echo:latest
$ curl http://localhost:8080 -d "this is a test message"
this is a test message

I then verified that ADDITIONAL_PACKAGE worked as expected using

faas-cli build -f echo.yml --build-arg ADDITIONAL_PACKAGE='curl build-essential'
$ docker run --rm -d -p 8080:8080 echo:latest
$ curl http://localhost:8080 -d "this is a test message"
this is a test message
$ docker run --rm echo:latest which make
/usr/bin/make

The last command verifies that build-essential installed correctly .

Types of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)
[ ] Version change (see: Impact to existing users)

Impact to existing users

Checklist:

[x] My code follows the code style of this project.
[x] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
[x] I've read the CONTRIBUTION guide
[x] I have signed-off my commits with git commit -s
[ ] I have added tests to cover my changes.
[ ] All new and existing tests passed.

alexellis commented 4 years ago

Approved, just need the README table to be updated next.

alexellis commented 4 years ago

In this PR ideally

LucasRoesler commented 4 years ago

@alexellis i just updated the readme

alexellis commented 4 years ago

Thank you for the PR 👍

openfaas / templates