Open viveksyngh opened 4 years ago
Thanks for the PR. Just bear in mind to fill out the template i.e. How Has This Been Tested?
Need to cross reference with https://github.com/openfaas-incubator/python-flask-template/pull/38
Need to cross reference with openfaas-incubator/python-flask-template#38
This has been handled within is_val
function.
Hi @alexellis, @viveksyngh
Sorry to hijack this PR, but I opened a similar, but more extensive issue (#205) in May. In it, I proposed opening a PR with my tried-and-tested solution, but since I got no response on the issue, I didn't at the time. I've now created it as #217.
Imho, my solution is less hackish, as it parses standard headers and doesn't require environment variable definition. It also is more extensive in functionality.
I'd be happy to propose similar changes to the flask templates (actually have those running privately too).
Signed-off-by: Vivek Singh vivekkmr45@yahoo.in
Description
Motivation and Context
Which issue(s) this PR fixes
Fixes #
How Has This Been Tested?
This has been tested on my local with kind
Types of changes
Impact to existing users
Checklist:
git commit -s