openfaas / templates

OpenFaaS Classic templates
https://www.openfaas.com
MIT License
280 stars 227 forks source link

Java8 Maven support #215

Open gopiteekenam opened 4 years ago

gopiteekenam commented 4 years ago

Java8 Template Maven support

Expected Behaviour

Observed that default Java 8 template has no support for Maven, hence enabled Maven support on Java8 as part of the project requirement As most of the companies / Projects are still mavenized would like to share the code snippet for Java8 Maven template

Current Behaviour

Currently there is no Maven support for existing Java8 template

Possible Solution

Provided Maven support to Java8 template along with mavenized build

Steps to Reproduce (for bugs)

Currently there is no support for Maven

Context

As most of our projects still on Maven we wanted to find a way to run openfaas with Maven builds, as there is out of box support for Maven enhanced the project to support both Maven and Gradle

Your Environment

alexellis commented 4 years ago

Hi thank you for stopping by and showing and interest in OpenFaaS.

Can you introduce yourself please? When you say "we", who is that?

For Maven I think requesting a template is reasonable, but it's more likely to be for the Java 11 templates. Is there any reason you're not asking about that? Isn't Java 8 EoL?

gopiteekenam commented 4 years ago

Thanks for quick reply @alexellis

I am Gopi, I am Technical Manager in Optum Global Services. As part of Serverless migration from other serverless framework to Openfaas, I have done PoC on Openfaas. Part of the PoC identified that out of box there is no Maven support for Java Template. So implemented the logic to enable Maven support for Java8 template.

As you rightly mentioned we are moving to Adoptive OpenJDK 11 and will be enabling Mavenization for Java 11 template.

As we already have the maven for Java 8, I don't think it will be more effort to enable Maven for Java 11