openfaas / templates

OpenFaaS Classic templates
https://www.openfaas.com
MIT License
276 stars 228 forks source link

Java8 template: added openfaas dependencies #216

Closed PaulienVa closed 3 years ago

PaulienVa commented 3 years ago

Openfaas dependencies needed to make the Java8 template compile

Description

The command faas-cli new --lang java8 java-function generated a java project which was not compiling due to missing dependencies in the gradle file.

Motivation and Context

Change is required to assure that users (still) using Java8 can generate a proper function template. Although Java8 is end-of-life, it is still used.

Which issue(s) this PR fixes

-

How Has This Been Tested?

Types of changes

Impact to existing users

Users using java8 can finally compile the generated template again

Checklist:

derek[bot] commented 3 years ago

Thank you for your contribution. I've just checked and your commit doesn't appear to be signed-off. That's something we need before your Pull Request can be merged. Please see our contributing guide. Tip: if you only have one commit so far then run: git commit --amend --signoff and then git push --force.