Closed spekulatius closed 3 years ago
Hey @alexellis,
any suggestions to resolve the failing verify.sh
run caused by the dot in the name?
Cheers, Peter
I don't have any suggestions at this time, but if you ask on Slack in #contributors, I'm sure someone will take a look and lend a hand.
No worries, time to drop it.
I'll reply in detail later on. Still processing stuff on my end.
Hey @alexellis
This PR adds PHP templates to add support for PHP 7.4 and 8.0. With this the composer version has been upgraded as well. The templates are mostly copied from the existing template.
I have left out 7.3 as it's almost out of support (tmr), but I could add it (if desired).
How Has This Been Tested?
The templates work. I've build and tested them.
Currently the
verify.sh
run fails silently. I assume it's caused by the dot in the path or template name. Not sure how this should be handled.Types of changes
Impact to existing users
Templates should affect existing users afaik.
Checklist:
git commit -s