Update node12 templates Dockerfile - Githubissues

openfaas / templates

OpenFaaS Classic templates

https://www.openfaas.com

MIT License

276 stars 228 forks source link

Update node12 templates Dockerfile #243

Closed james426759 closed 3 years ago

james426759 commented 3 years ago

updata nodejs12 templates dockerfile

Description

updata nodejs12 dockerfile (add expose port)

Motivation and Context

[x] I have raised an issue to propose this change (required)

How Has This Been Tested?

Types of changes

[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)
[ ] Version change (see: Impact to existing users)

Impact to existing users

Checklist:

[x] My code follows the code style of this project.
[x] My change requires a change to the documentation.
[x] I have updated the documentation accordingly.
[x] I've read the CONTRIBUTION guide
[x] I have signed-off my commits with git commit -s
[x] I have added tests to cover my changes.
[x] All new and existing tests passed.

derek[bot] commented 3 years ago

Thank you for your contribution. I've just checked and your commit doesn't appear to be signed-off. That's something we need before your Pull Request can be merged. Please see our contributing guide. Tip: if you only have one commit so far then run: git commit --amend --signoff and then git push --force.