update node12 templates Dockerfile - Githubissues

openfaas / templates

OpenFaaS Classic templates

https://www.openfaas.com

MIT License

276 stars 228 forks source link

update node12 templates Dockerfile #244

Closed james426759 closed 2 years ago

james426759 commented 3 years ago

Signed-off-by: james426759 james759426@gmail.com

Description

update node12 templates Dockerfile (add expose port)

Motivation and Context

[x] I have raised an issue to propose this change (required)

Which issue(s) this PR fixes

How Has This Been Tested?

Types of changes

[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)
[ ] Version change (see: Impact to existing users)

Impact to existing users

Checklist:

[x] My code follows the code style of this project.
[x] My change requires a change to the documentation.
[x] I have updated the documentation accordingly.
[x] I've read the CONTRIBUTION guide
[x] I have signed-off my commits with git commit -s
[ ] I have added tests to cover my changes.
[ ] All new and existing tests passed.

alexellis commented 3 years ago

I'm sorry but you really have to do your bit here and fill out the template.

If we don't see that effort from you, then the issue/PR will be closed.