MAX_RAW_SIZE limit for bodyParse.raw

fundef1 commented 3 years ago

moved rawLimit out of if clause , so it can be applied to RAW_BODY as well. Is more consistent this way.

Motivation and Context

cfr. https://github.com/openfaas/templates/issues/245

Which issue(s) this PR fixes

Fixes #245

How Has This Been Tested?

manually ;-)

Types of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)
[ ] Version change (see: Impact to existing users)

Impact to existing users

none,

Checklist:

[x ] My code follows the code style of this project.
[ x] My change requires a change to the documentation.
[ x] I have updated the documentation accordingly.
[ ] I've read the CONTRIBUTION guide
[ ] I have signed-off my commits with git commit -s
[ ] I have added tests to cover my changes.
[ ] All new and existing tests passed.

derek[bot] commented 3 years ago

Thank you for your contribution. I've just checked and your commit doesn't appear to be signed-off. That's something we need before your Pull Request can be merged. Please see our contributing guide. Tip: if you only have one commit so far then run: git commit --amend --signoff and then git push --force.

alexellis commented 3 years ago

Thanks for your interest in the project, please can you run the command that Derek has provided?

fundef1 commented 3 years ago

I'll try again over the weekend. The command provided by derek doesn't work (as I don't have a local copy - cfr webui).

alexellis commented 3 years ago

I'm not sure I understand the comment about Derek.

Are you saying you don't have a terminal and git available?

@Waterdrips could you take over this PR please? It seems like it would be useful for the community.

fundef1 commented 3 years ago

sorry didn't get around to this.

But yes, to answer your question about derek: I edited the documentation directly on github.com without cloning/forking/... For a quick copy/paste like that it's the path of least resistance.... until derek.

I understand the need for your hefty CONTRIBUTING.md ... but it is a little bureaucratic for a two-line edit ;-/ (when you are just playing around that is, I guess if you have everything set up already it's smooth as butter)

alexellis commented 3 years ago

Here is the absolute minimum required for every contribution:

https://github.com/openfaas/faas/blob/master/CONTRIBUTING.md#sign-your-work

But yes, to answer your question about derek: I edited the documentation directly on github.com without cloning/forking/... For a quick copy/paste like that it's the path of least resistance.... until derek.

This actually creates a fork automatically ☝️

You can also sign-off that commit in the UI, just read the section in the contributing guide on how.

Here's an example of something you can copy/paste into the UI:

Add alexellis to the .DEREK.yml file

We need to add alexellis to the .DEREK.yml file for project maintainer
duties.

Signed-off-by: Alex Ellis <alex@openfaas.com>

My concern with the approach of directly editing code in the UI is that it's hard to verify changes don't have syntax errors.

If using git to make code changes feels too beaucratic or too heavy-weight, that's OK. We can take this one on as it seems like it will benefit a broader audience.

I've pinged @Waterdrips to help.

openfaas / templates