openfaas / templates

OpenFaaS Classic templates
https://www.openfaas.com
MIT License
281 stars 227 forks source link

Go Version Update from 1.15 to 1.16 #268

Closed mrwormhole closed 2 years ago

mrwormhole commented 3 years ago

The Go version should be above 1.15 since 1.17 is released.

Expected Behaviour

The Go version in the templates should be at least version 1.16

Current Behaviour

Currently used version was 1.15 and It was causing some issues when docker tried to pull 1.15 alpine(1.13) alpine image for arm64. Other versions didn't have this issue.

Are you a GitHub Sponsor (Yes/No?)

Check at: https://github.com/sponsors/openfaas

List All Possible Solutions and Workarounds

Use aarch64 instead of arm64 tag in template's dockerfile Change the go version to 1.16 or 1.17

Which Solution Do You Recommend?

Update to go version to 1.16

Steps to Reproduce (for bugs)

  1. Try to do faas-cli up on arm64 machine after you modified the template's dockerfile from amd64 to arm64
  2. You will get an output saying you requested amd64 image from arm64 machine on golang alpine docker image before it takes the arg env variables. I have added the image(reproducable steps) to the PR

Context

It was not very smooth experience for arm64 pi machine for faasd. I would definitely recommend using faas-cli build and deploy rather than just single up. It seems to be little tricky without modify template's dockerfile unless you are on amd64 architecture

Your Environment