openfaas / templates

OpenFaaS Classic templates
https://www.openfaas.com
MIT License
276 stars 228 forks source link

fix: install faas-cli as a seperate CI step #269

Closed LucasRoesler closed 2 years ago

LucasRoesler commented 2 years ago

Description

Run faas-cli install in it's own step to because this will install it into the users PATH for us and the setup/verify script will intelligently skip the faas-cli install step. This avoids a bug where the script assumes that the cli was installed into the tmp dir instead of the PATH.

Apparently, the runner now has enough permissions to do this, but it couldn't before.

Motivation and Context

None, this was requested in Slack

Which issue(s) this PR fixes

NA

How Has This Been Tested?

The CI flow passed correctly in my fork.

Types of changes

Impact to existing users

None, this just fixes the CI process

Checklist:

alexellis commented 2 years ago

Thank you for the quick fix @LucasRoesler