Fixed mismatching node template names in README

cactysman commented 2 years ago

Description

The names for the Node.js templates in the README document were all named node14. This pull request fixes that.

Motivation and Context

The README can be a bit misleading at first without this change.

[x] I have raised an issue to propose this change (required)

Which issue(s) this PR fixes

Fixes #277

How Has This Been Tested?

This change only affects documentation and requires no testing.

Types of changes

[x] Documentation (non-breaking change)
[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)
[ ] Version change (see: Impact to existing users)

Impact to existing users

This change fixes invalid documentation and attempts to solve potential confusion with it.

Checklist:

[ ] My code follows the code style of this project.
[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
[x] I've read the CONTRIBUTION guide
[x] I have signed-off my commits with git commit -s
[ ] I have added tests to cover my changes.
[ ] All new and existing tests passed.

Honestly I did not test this, but if anything should break here, I'm 100% certain it's not my fault 😮

derek[bot] commented 2 years ago

Thank you for your contribution. unfortunately, one or more of your commits are missing the required "Signed-off-by:" statement. Signing off is part of the Developer Certificate of Origin (DCO) which is used by this project.

Read the DCO and project contributing guide carefully, and amend your commits using the git CLI. Note that this does not require any cryptography, keys or special steps to be taken.

:bulb: Shall we fix this?

This will only take a few moments.

First, clone your fork and checkout this branch using the git CLI.

Next, set up your real name and email address:

git config --global user.name "Your Full Name" git config --global user.email "you@domain.com"

Finally, run one of these commands to add the "Signed-off-by" line to your commits.

If you only have one commit so far then run: git commit --amend --signoff and then git push --force. If you have multiple commits, watch this video.

Check that the message has been added properly by running "git log".

alexellis commented 2 years ago

Thanks for filling out the PR template. Glad you were able to get the DCO sorted too 👍

For any future issues, please don't delete the issue template next time 😄

openfaas / templates