openfaas / templates

OpenFaaS Classic templates
https://www.openfaas.com
MIT License
278 stars 227 forks source link

Use of-watchdog 0.9.3 to suppress custom health check logging messages #284

Closed nitishkumar71 closed 2 years ago

nitishkumar71 commented 2 years ago

Signed-off-by: Nitishkumar Singh nitishkumarsingh71@gmail.com

of-watchdog version to 0.9.3

Description

of-watchdog version to 0.9.3

Motivation and Context

Which issue(s) this PR fixes

Fixes #283

How Has This Been Tested?

  1. Made changes into template
  2. Created new function with from local templates using faas-cli new java11-test --lang java11 -f <path of template>
  3. Build function faas-cli build -f ./java11-test.yml
  4. Deploy function faas-cli deploy -f ./java11-test.yml
  5. Invoke function

    Types of changes

    • [ ] Bug fix (non-breaking change which fixes an issue)
    • [ ] New feature (non-breaking change which adds functionality)
    • [ ] Breaking change (fix or feature that would cause existing functionality to change)
    • [x] Version change (see: Impact to existing users)

Impact to existing users

There should be no impact. As only kube-probe log is disabled

Checklist:

alexellis commented 2 years ago

/set title: Use of-watchdog 0.9.3 to suppress custom health check logging messages

alexellis commented 2 years ago

@nitishkumar71 I had feedback from a few users that they like to know why something was changed not just how it was changed. What do you think of the new title?

nitishkumar71 commented 2 years ago

@nitishkumar71 I had feedback from a few users that they like to know why something was changed not just how it was changed. What do you think of the new title?

Make sense, will take care of this in future