openfaas / templates

OpenFaaS Classic templates
https://www.openfaas.com
MIT License
276 stars 228 forks source link

Missing use ADDITIONALPACKAGE on GoLang template #309

Closed raniellyferreira closed 7 months ago

raniellyferreira commented 7 months ago

I noticed that the GoLang template in the OpenFaaS templates repository is missing the use of ADDITIONALPACKAGE in the Dockerfile. This can be seen at line 42 in the Dockerfile:

RUN apk --no-cache add ca-certificates ${ADDITIONAL_PACKAGE}

The ADDITIONAL_PACKAGE variable allows users to specify additional packages to be installed in the Docker image. It would be helpful to include this line in the template so that users can easily add extra packages when building their functions.

Reference: OpenFaaS templates Dockerfile

Please let me know if there's anything else I can help you with!

alexellis commented 7 months ago

The warning in the Go template is very clear, do not use it. It's deprecated.

Use golang-middleware.

Please also don't delete the issue template, but include all the details requested - these are key for asynchronous communication, even if you don't think they're meaningful.

https://raw.githubusercontent.com/openfaas/templates/master/.github/ISSUE_TEMPLATE.md