openfaas / templates

OpenFaaS Classic templates
https://www.openfaas.com
MIT License
279 stars 228 forks source link

Unknown flag: chown in nodejs template #52

Open sdf611097 opened 6 years ago

sdf611097 commented 6 years ago

COPY --chown is not work on docker 17.03.2-ce

Expected Behaviour

fass-cli build will success

Current Behaviour

It will failed at docker build.

... Step 14 : COPY --chown=app:app function/ . Unknown flag: chown

Possible Solution

Do not use COPY --chown in Dockerfile

Steps to Reproduce (for bugs)

  1. Using a bit older docker
  2. js-fn.yml to specify "lang: node"
  3. faas-cli build -f js-fn.yml

Context

Your Environment

oanguin commented 5 years ago

Any updates on this issue.

alexellis commented 5 years ago

Hi @oanguin, if you look at the PR, then you will see that @sdf611097 was asked for input over 7 months ago and still hasn't replied.

If you'd like this feature, I'd suggest working on the PR or submitting your own PR.

The key thing lacking from the PR was testing and evidence that it didn't introduce breakage.

Hope that helps,

Alex