openfga / api

Protocol Buffers used by OpenFGA
Apache License 2.0
18 stars 10 forks source link

feat: add support for modular models metadata #141

Closed ewanharris closed 6 months ago

ewanharris commented 6 months ago

Description

This PR introduces the metadata required for modular models. Namely, the file and module fields on TypeDefintions, Relations, and Conditions.

I'm very much a protobuf noob so please call out any extra additions that are needed, I tried to keep the validation aligned with what exists currently.

References

Closes #137

See the updated RFC PR for an example of these additions https://github.com/openfga/rfcs/pull/18

Review Checklist

jon-whit commented 6 months ago

@ewanharris would you please, for the record, include some examples of these protobufs for some file and module structures? That will make future me understand the field structure of these changes better (when I reflect back on this), and it will make it easier to review at the current time as well.