openfga / api

Protocol Buffers used by OpenFGA
Apache License 2.0
18 stars 10 forks source link

fix: regenerating types after removing `ObjectOrUserset` from API #173

Closed willvedd closed 3 months ago

willvedd commented 3 months ago

Description

ObjectOrUserset was removed in #171 but types were not regenerated. This PR introduces those chagnes.

References

Original PR: #171

Review Checklist

rhamzeh commented 3 months ago

@willvedd can you make sure you are updating the swagger file too?

rhamzeh commented 3 months ago

We should probably hav a CI job that blocks PRs that don't regen the protos and the swagger

willvedd commented 3 months ago

We should probably hav a CI job that blocks PRs that don't regen the protos and the swagger

We actually had that for the swagger file but not for the generated types. I opened #174 to address this. Once this PR gets merged in, that PR should begin passing all checks!