openfga / api

Protocol Buffers used by OpenFGA
Apache License 2.0
18 stars 10 forks source link

CI: prevent uncommitted artifact changes #174

Closed willvedd closed 3 months ago

willvedd commented 3 months ago

Description

Adds checks for diffs on the generated Go files; currently we're only checking for diffs on the swagger file.

This is proven to work because of the failed diff-openapi job that is detecting the very exact thing we're trying to prevent.

Inspired by #173 which could have been detected and prevented. ~Once that PR is merged, this job will start passing.~ Update: that PR was merged and the diff-openapi job is now passing 🎉 .

References

Inspiration: #173 Proof of concept: https://github.com/openfga/api/actions/runs/9604720835/job/26490812942?pr=174

Review Checklist