openfga / api

Protocol Buffers used by OpenFGA
Apache License 2.0
19 stars 14 forks source link

feat(list-user): add `exclude` list in ListUserResponse #179

Closed lalalalatt closed 3 months ago

lalalalatt commented 3 months ago

Description

I am working on https://github.com/openfga/openfga/issues/1692, and I add a excluded field as describe in the mentioned issue.

References

Review Checklist

linux-foundation-easycla[bot] commented 3 months ago

CLA Signed


The committers listed above are authorized under a signed CLA.

willvedd commented 3 months ago

@lalalalatt Appreciate your contribution here. We actually previously implemented a very similar approach to the one you've implemented. For example, please see https://github.com/openfga/api/pull/171. Its a fine approach but doesn't take into account any feedback or use cases from customers. For that reason, I don't see this as being actionable or ready to review yet.

lalalalatt commented 3 months ago

@lalalalatt Appreciate your contribution here. We actually previously implemented a very similar approach to the one you've implemented. For example, please see #171. Its a fine approach but doesn't take into account any feedback or use cases from customers. For that reason, I don't see this as being actionable or ready to review yet.

Okay, I see. If there are any updates, please inform me. Thanks!

willvedd commented 3 months ago

@lalalalatt As mentioned in the other PR, I appreciate the contribution and will let you know if/when the excluded users is able to be implemented.