chore: change validation patterns

miparnisari commented 2 years ago

You can ignore the swagger.json file when reviewing this PR, as it's generated by buf generate.

Description

Add a few examples in the proto files
Whenever we have a mix of min_len/max_len and pattern validation, remove the min_len and max_len in favor of an updated pattern that includes the length. See https://github.com/envoyproxy/protoc-gen-validate/issues/79
Both store_id and authorization_model_id are generated with https://github.com/oklog/ulid, which generates 26 characters. Change the validation for these fields

References

n/a

Review Checklist

[x] I have added documentation for new/changed functionality in this PR or in openfga.dev
[x] The correct base branch is being used, if not main

jon-whit commented 2 years ago

Need to run buf generate to regen the OpenAPI file based on the changes. Otherwise the diff-openapi job will fail in the checks.

miparnisari commented 2 years ago

Need to run buf generate to regen the OpenAPI file based on the changes. Otherwise the diff-openapi job will fail in the checks.

i did do that 🤔

jon-whit commented 2 years ago

Need to run buf generate to regen the OpenAPI file based on the changes. Otherwise the diff-openapi job will fail in the checks.

i did do that 🤔

Did you also run the update swagger script?

miparnisari commented 2 years ago

Need to run buf generate to regen the OpenAPI file based on the changes. Otherwise the diff-openapi job will fail in the checks.

i did do that 🤔

Did you also run the update swagger script?

Oh i didn't realize this script existed! Just ran it.

openfga / api