feat: make helm hooks mandatory

jbouchery commented 5 months ago

Description

I saw that this PR added the Helm Hooks to the migration job https://github.com/openfga/helm-charts/pull/70. I think it could be better to make them mandatory instead of default in the values (so it can't be overridden). In addition, i deleted the initContainer that is deprecated when using Helm Hooks.

References

The PR introducing the migration Helm Hooks https://github.com/openfga/helm-charts/pull/70

Review Checklist

[ ] I have clicked on "allow edits by maintainers".
[ ] I have added documentation for new/changed functionality in this PR or in a PR to openfga.dev [Provide a link to any relevant PRs in the references section above]
[x] The correct base branch is being used, if not main
[ ] I have added tests to validate that the change in functionality is working as expected

linux-foundation-easycla[bot] commented 5 months ago

The committers listed above are authorized under a signed CLA.

:white_check_mark: login: jbouchery (86caad5510459248c7656a5efc551f245630c8cf)

rhamzeh commented 5 months ago

Thanks for the PR @jbouchery!

While the team reviews the PR, may I ask you to:

Sign the Linux Foundation's EasyCLA? As a Cloud Native Computing Sandbox project, we cannot merge PRs that haven't signed the CLA.
Resolve the merge conflicts - There seem to be some merge conflicts around your PR (Mostly the app version. You may have to bump this again if another PR is merged before yours)

jbouchery commented 5 months ago

Hi @rhamzeh,

Thanks for the feedback !

I Signed the Linux Foundation's EasyCLA as you said. I also reviewed the merge conflicts but my PR only involve a change of the Helm Chart, not the application. I don't think i have to bump de appVersion in this case.

supercairos commented 1 month ago

Please don't male the hooks mandatory as it seams to be breaking on ArgoCD deployement...

I had to do this :

  migrate:
    annotations:
      helm.sh/hook: null
      helm.sh/hook-weight: null
      helm.sh/hook-delete-policy: null

in order to make it helm on argocd

openfga / helm-charts