fix: add image pull secrets to migration job

rorynickolls-skyral commented 1 month ago

Adds image pull secrets to the migration job.

Description

Image pull secrets are currently configurable for the OpenFGA deployment, but not the migrate job.

This makes it difficult to use the chart in scenarios where you want to pull images from a private registry (e.g. a Docker Hub mirror).

Another option here is to add them to the service account, but I think this way is clearer and compatible if the service account is disabled.

I have tested this locally and it allows the chart to be installed with all images configured to pull from a private registry.

If the change warrants more discussion I'm happy to open up an issue - but it looks like something that might have just been missed out.

[x] I have clicked on "allow edits by maintainers".
[ ] I have added documentation for new/changed functionality in this PR or in a PR to openfga.dev [Provide a link to any relevant PRs in the references section above]
[x] The correct base branch is being used, if not main
[ ] I have added tests to validate that the change in functionality is working as expected

linux-foundation-easycla[bot] commented 1 month ago

The committers listed above are authorized under a signed CLA.

:white_check_mark: login: rorynickolls-skyral (ed78b12ad552bf04ae0b8e26c4c1e73a5e31b8a1, 9bf65f85a18c97024f587bdc4fa7cc032ad602b2)

jon-whit commented 1 month ago

@rorynickolls-skyral you need to bump the chart version as well. Then we can merge 👍

rorynickolls-skyral commented 1 month ago

Thanks @jon-whit. Bumped to 0.2.4.