feat: include "extraEnvVars" as part of the migration job

Oscmage commented 6 months ago

Description

From reading the code I see no way of providing the same extraEnvVars as done to the deployment for the migration job. The only way I can see is to directly add datastore.uri as part of the values file which is not something we want since it is a secret and something we want to commit to a git repository. It is from what I've found (please correct me if so) not possible to to use something like ExternalSecret to load the value dynamically rather than hardcoding it in the values file.

I'd like to be able to do something like

We are currently running this version of the chart in production and it works just fine.

openfga:
  extraEnvVars:
    - name: OPENFGA_DATASTORE_URI
      valueFrom:
        secretKeyRef:
          name: openfga-external-secrets
          key: OPENFGA_DATASTORE_URI

but it is currently not picked up by the migration job.

References

How it is done in the deployment file:

https://github.com/openfga/helm-charts/blob/40ea4e1936efb04da540d1d2afe7e6375eedda3f/charts/openfga/templates/deployment.yaml#L326

Review Checklist

[X] I have clicked on "allow edits by maintainers".
[X] I have added documentation for new/changed functionality in this PR or in a PR to openfga.dev [Provide a link to any relevant PRs in the references section above]
[X] The correct base branch is being used, if not main
[X] I have added tests to validate that the change in functionality is working as expected

linux-foundation-easycla[bot] commented 6 months ago

The committers listed above are authorized under a signed CLA.

:white_check_mark: login: Oscmage / name: Oscar Evertsson (f6ec070cf7c6deb678e86d6a9f079a385b6de68e, a939b406b99a7cffd9b3a1fdac5d5af93c67af9d, 05c2ecd1ac6a2de298fa2f4c367368a3be42149f, 8d9bfa38802f838a67888e1a86e05830cfa925b9, ebf6656360366ba4818d7657eec19408324bc369)
:white_check_mark: login: rhamzeh / name: Raghd Hamzeh (72d817ed5443f78e78a5408009d0e3c9d5694c3b)
:white_check_mark: login: ewanharris / name: Ewan Harris (b665921e3f679b9a36bd79f59edd0b3327f497eb, 25d550d15d48b5f5e2fd9985a28464c463e7ba5b)

Oscmage commented 6 months ago

@ewanharris Make sense, thanks!

Oscmage commented 6 months ago

Resolved merge conflict due to other changes.

jon-whit commented 6 months ago

@Oscmage please don't forget to bump the chartVersion.

Oscmage commented 6 months ago

@Oscmage please don't forget to bump the chartVersion.

Sorry might have gotten lost in the merge.

@jon-whit Do you mean charts/openfga/Chart.yaml version? Did that change now.

openfga / helm-charts