openfga / helm-charts

Official Helm charts for the OpenFGA project.
https://openfga.dev
Apache License 2.0
24 stars 37 forks source link

feat: add extraMounts and volumes to migrate job #147

Closed wenzel-felix closed 3 months ago

wenzel-felix commented 4 months ago

This PR adds the extraVolumes and extraVolumeMounts to the migration job.

Description

As this PR (https://github.com/openfga/helm-charts/pull/142) also already did, I added extraVolumes and extraVolumeMounts to the migrate job allowing for different scenarios not possible without, eg. mounting CA bundles or mounting secrets via SPC for the database credentials to be used by the job.

Compared to the other PR I also added the default values in the values.yaml and added the new values to the validation schema.

References

https://github.com/openfga/helm-charts/pull/142

Review Checklist

linux-foundation-easycla[bot] commented 4 months ago

CLA Signed


The committers listed above are authorized under a signed CLA.

wenzel-felix commented 4 months ago

Hi @rhamzeh / @jon-whit , sorry for asking again, but could you review the changes? These are very minor additions to the migration hook job.