openfga / helm-charts

Official Helm charts for the OpenFGA project.
https://openfga.dev
Apache License 2.0
18 stars 29 forks source link

feat: add parameters to allow migrate job to use its own database account and service account #98

Open evankanderson opened 5 months ago

evankanderson commented 5 months ago

Fixes #95

Description

Add parameters to enable running the migration job with a different database access level.

References

(Unfortunately, our other examples of doing this aren't public)

Review Checklist

evankanderson commented 5 months ago

Interesting... the Contribution Guidelines say the CLA is required, but don't also mention DCO (which seems belt & suspenders to me).

evankanderson commented 5 months ago

I'm not sure how this is supposed to be tested. I did some manual testing, but didn't see any testing directions.

evankanderson commented 5 months ago

I updated the values.schema.json -- I can squash that to a single PR if needed.

jon-whit commented 5 months ago

@evankanderson thanks for the contribution!

Do you mind doing a screen capture of this working in action? That will help me manually verify it a little better and it could help future eyes landing on this to know how to use it a little better.

rhamzeh commented 5 months ago

Interesting... the Contribution Guidelines say the CLA is required, but don't also mention DCO (which seems belt & suspenders to me).

Apologies for the confusion - we just disabled the DCO, it was from the time the CLA was not enabled on this repo. Thanks for pointing it out!