Closed ewanharris closed 3 months ago
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 88.13%. Comparing base (
78daf78
) to head (bacbd79
). Report is 5 commits behind head on main.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Description
This is an initial attempt at introducing support for the experimental consistency option in the relevant APIs, this is supported on the following APIs:
And the following SDK methods
When introducing this option to the
OpenFGAClient
class, we decided that this option fits better in theoptions
object as opposed to therequest
object as it's more of an "override" choice akin to the existing model ID and store ID.So the usage looks like so
I think there is a question around the correct usage for
batchCheck
, in that instance should the consistency choice be per check or for the entirebatchCheck
, currently we have it for the entirebatchCheck
but personally I don't think this is ideal.References
Review Checklist
main