fix: move condition definition to own mode

d-jeffery commented 7 months ago

Declared a new mode for definitions of conditions, and their parameters and types.

Following is now valid;

model
    schema 1.1
type list
type map

Description

Moved condition definition to own mode
Specified shared tokens for all modes at head of Lexer
Overrode types in conditions to reduce need to rewrite parser logic to deal with new token types
Updated 4 tests because their type suggestion order had now changed (least impactful I could be)
Automatic linting of both tests and antlr4 files
Added a small test

[ ] I have clicked on "allow edits by maintainers".
[ ] I have added documentation for new/changed functionality in this PR or in a PR to openfga.dev [Provide a link to any relevant PRs in the references section above]
[ ] The correct base branch is being used, if not main
[ ] I have added tests to validate that the change in functionality is working as expected

rhamzeh commented 7 months ago

@d-jeffery, this replaces #109 right? Can we close that?

And do you think we can redo #104 after we merged the changes in this PR?

d-jeffery commented 7 months ago

@d-jeffery, this replaces #109 right? Can we close that?

Yes!

And do you think we can redo #104 after we merged the changes in this PR?

Sounds good.