chore: bump go version to 1.21 - Githubissues

openfga / language

Grammar for the OpenFGA modeling language

https://openfga.dev

Apache License 2.0

17 stars 7 forks source link

chore: bump go version to 1.21 #155

Closed ewanharris closed 7 months ago

ewanharris commented 7 months ago

Description

Now that 1.22 is out in theory we can bump this, it should fix the golangci-lint issues that we're seeing due to their minimum version being bumped

Alternatively, we could

pin to a version of golangci-lint other than latest
match how CI works for JS and run our vulncheck and linting on a newer version of Go and then run tests using all our supported versions of Go rather than pointing to the go.mod file.

Edit:

I had to move this to 1.21.3 due to this being the version set in https://github.com/openfga/api/blob/main/proto/go.mod and go was enforcing that be set rather than 1.21

References

Review Checklist

[x] I have clicked on "allow edits by maintainers".
[ ] I have added documentation for new/changed functionality in this PR or in a PR to openfga.dev [Provide a link to any relevant PRs in the references section above]
[x] The correct base branch is being used, if not main
[ ] I have added tests to validate that the change in functionality is working as expected

ewanharris commented 7 months ago

New failure is why I think we should split out lint and vulncheck to run on a newer (or even latest) version of Go and then test against a supported range to avoid govulncheck flagging issues in an older version