search

openfga / language

Grammar for the OpenFGA modeling language
https://openfga.dev
Apache License 2.0
18 stars 7 forks source link

Grammar refactor #24

Open d-jeffery opened 1 year ago

d-jeffery commented 1 year ago

When time allows, we can build off the following PR and improve the tokenization of the lexer and parser.

https://github.com/openfga/language/pull/22

Core problem stopping this is the character chosen to trigger a comment - it is very difficult to match with best practices in ANTLR4. https://github.com/antlr/grammars-v4/blob/3ecefc5f8ed0a38ff4b68705bcfd521bcd59f8d3/python/python2-js/Python2.g4#L454

aaguiarz commented 1 week ago

@rhamzeh is this still a problem?

Check https://github.com/mindersec/minder/blob/main/internal/authz/model/minder.fga