fix: Added correct failure messages to existing, failing tests - Githubissues

openfga / language

Grammar for the OpenFGA modeling language

https://openfga.dev

Apache License 2.0

18 stars 7 forks source link

fix: Added correct failure messages to existing, failing tests #33

Closed d-jeffery closed 1 year ago

d-jeffery commented 1 year ago

Description

Updated tests with invalid syntax to have expected error message.

References

Associated with change issue https://github.com/openfga/language/issues/30

Review Checklist

[ ] I have clicked on "allow edits by maintainers".
[ ] I have added documentation for new/changed functionality in this PR or in a PR to openfga.dev [Provide a link to any relevant PRs in the references section above]
[x] The correct base branch is being used, if not main
[ ] I have added tests to validate that the change in functionality is working as expected

d-jeffery commented 1 year ago

Is the expectedError correct now? Are we returning the proper errors?

No, I was going to leave in the metadata until after adding the validation entrypoint, as I will need to try-catch transformDslToJSON in the jest suite otherwise.

I can add the proper errors, line and col fields prior to the validation PR if preferred.