fix: ClientTuple condition property type

openfga / python-sdk

OpenFGA SDK for Python 3 - https://pypi.org/project/openfga-sdk/

https://openfga.dev

Apache License 2.0

35 stars 12 forks source link

fix: ClientTuple condition property type #100

Closed gilion-joel-b closed 3 months ago

gilion-joel-b commented 3 months ago

Changes type of condition property on ClientTuple

Description

ClientTuple's property condition is by default set to None - indicating it is nullable. It's type does not reflect that however. Therefore I have simply added a union between the existing typ RelationshipCondition and None.

Review Checklist

[X] I have clicked on "allow edits by maintainers".
[ X] I have added documentation for new/changed functionality in this PR or in a PR to openfga.dev [Provide a link to any relevant PRs in the references section above]
[X ] The correct base branch is being used, if not main
[X ] I have added tests to validate that the change in functionality is working as expected

linux-foundation-easycla[bot] commented 3 months ago

The committers listed above are authorized under a signed CLA.

:white_check_mark: login: gilion-joel-b / name: Joel (5a4bc3f5eff1a72ad38b3335a9f74e987de40c9f, c491b0c09af8b04d48954685b868a5971e13ebbe)

codecov-commenter commented 3 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 68.06%. Comparing base (664b0b9) to head (5a4bc3f).

Additional details and impacted files

```diff @@ Coverage Diff @@ ## main #100 +/- ## ======================================= Coverage 68.06% 68.06% ======================================= Files 114 114 Lines 8974 8974 ======================================= Hits 6108 6108 Misses 2866 2866 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

rhamzeh commented 3 months ago

Thanks @gilion-joel-b !