Closed evansims closed 2 months ago
Attention: Patch coverage is 63.46154%
with 19 lines
in your changes missing coverage. Please review.
Project coverage is 69.16%. Comparing base (
4ecb08f
) to head (b3225c0
).
Files with missing lines | Patch % | Lines |
---|---|---|
openfga_sdk/telemetry/attributes.py | 67.74% | 10 Missing :warning: |
openfga_sdk/telemetry/metrics.py | 57.14% | 9 Missing :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Can you also please:
Update the documentation page with
- the defaults
- How to configure it
- Update the example with a sample configuration?
- Add validation that they're not configuring with invalid meter/attribute names?
I'd prefer to do a documentation pass as a separate PR, but yup, that's on my radar.
Right now providing an invalid meter/attribute would just be ignored; I can add an exception for those instances. Updated the PR with that; added a test to cover it
Description
This PR fixes several bugs identified in the recent OpenTelemetry improvements:
http_client_request_duration
being reported in seconds rather than the intended millisecondsqueryDuration()
andrequestDuration()
.queryDuration()
andrequestDuration()
may not have updated their histograms reliably whenattr_http_client_request_duration
orattr_http_server_request_duration
(respectively) were not enabled (which is the default)References
Review Checklist
main