openfga / python-sdk

OpenFGA SDK for Python 3 - https://pypi.org/project/openfga-sdk/
https://openfga.dev
Apache License 2.0
38 stars 15 forks source link

fix: ensure `max_parallel_requests` is an `int` value in `batch_check` #132

Closed evansims closed 1 month ago

evansims commented 1 month ago

Description

This change addresses a bug where batch_check typing was configured to only accept string values as part of the options dict; however, the max_parallel_requests option (later used by the ThreadPoolExecutor) requires this to be an integer value.

This PR:

References

closes #128

Review Checklist

codecov-commenter commented 1 month ago

Codecov Report

Attention: Patch coverage is 75.00000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 69.16%. Comparing base (e2ce832) to head (a118952).

Files with missing lines Patch % Lines
openfga_sdk/client/client.py 75.00% 1 Missing :warning:
openfga_sdk/sync/client/client.py 75.00% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #132 +/- ## ========================================== - Coverage 69.16% 69.16% -0.01% ========================================== Files 121 121 Lines 9982 9988 +6 ========================================== + Hits 6904 6908 +4 - Misses 3078 3080 +2 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.