Closed evansims closed 1 month ago
Attention: Patch coverage is 75.00000%
with 2 lines
in your changes missing coverage. Please review.
Project coverage is 69.16%. Comparing base (
e2ce832
) to head (a118952
).
Files with missing lines | Patch % | Lines |
---|---|---|
openfga_sdk/client/client.py | 75.00% | 1 Missing :warning: |
openfga_sdk/sync/client/client.py | 75.00% | 1 Missing :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Description
This change addresses a bug where
batch_check
typing was configured to only acceptstr
ing values as part of theoptions
dict
; however, themax_parallel_requests
option (later used by theThreadPoolExecutor
) requires this to be anint
eger value.This PR:
str | int
as values for thedict
.max_parallel_requests
was passed as anstr
orint.
str
, and Python verifies the string represents a numerical value (usingisdigit()
), then the value is cast to anint
and used.int,
the value is used.References
closes #128
Review Checklist
main