openfga / python-sdk

OpenFGA SDK for Python 3 - https://pypi.org/project/openfga-sdk/
https://openfga.dev
Apache License 2.0
38 stars 15 forks source link

feat: support auto-retry of failed network requests to `/oauth/token` endpoint #79

Closed evansims closed 7 months ago

evansims commented 7 months ago

Description

This pull request:

This PR also bumps the pytest-cov dependency from >= 4.1.0, < 5 to >= 5, < 6, as no changes were required for our tests to support the latest version.

References

Closes https://github.com/openfga/python-sdk/issues/18

Review Checklist

evansims commented 7 months ago

@rhamzeh I'm currently re-using the existing max_retry and min_wait_in_ms configuration values (that we're using for FGA retries) to configure this auth retry strategy.

Do you think this is appropriate? Should we be adding new configuration properties?

rhamzeh commented 7 months ago

Do you think this is appropriate? Should we be adding new configuration properties?

No, reusing is fine. It's what we do in the other SDKs.

evansims commented 7 months ago

Updated based on feedback from https://github.com/openfga/sdk-generator/pull/335