Closed evansims closed 2 months ago
Attention: Patch coverage is 95.45455%
with 1 lines
in your changes are missing coverage. Please review.
Project coverage is 69.02%. Comparing base (
f18f786
) to head (9989f94
).
Files | Patch % | Lines |
---|---|---|
openfga_sdk/configuration.py | 95.45% | 1 Missing :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
@rhamzeh Updated with your feedback 👍
Description
This PR:
RetryParams
class does not permitmax_retry
to exceed the hardcoded limit of 15 retries, as configured by the SDK Generator.Other small bug fixes and improvements to the Configuration were made, which I noticed as I was writing the unit tests:
disabled_client_side_validations
was not working reliably and was unnecessarily using the__setattr__
magic method. This introduced a tiny and unnecessary performance hit when making ANY configuration adjustments. I've created a getter/setter for this property to resolve this.min_wait_in_ms
was not checking for negative values, or indeed if the passed value was an integer at all.api_scheme
setter was not validating the assigned string as being either HTTP or HTTPS.References
Review Checklist
main